Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: react v19 #4558

Merged
merged 4 commits into from
Dec 19, 2024
Merged

chore: react v19 #4558

merged 4 commits into from
Dec 19, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Update

Summarise concisely:

What is expected?

Migrate to react 19

@matthprost matthprost self-assigned this Dec 10, 2024
@matthprost matthprost requested review from a team and lisalupi as code owners December 10, 2024 14:50
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: de468d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/icons Minor
@ultraviolet/form Minor
@ultraviolet/plus Minor
@ultraviolet/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost force-pushed the chore/react-19 branch 3 times, most recently from 0fa5f82 to 4053e0e Compare December 10, 2024 14:58
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (4d8a5b5) to head (de468d7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/Expandable/index.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4558      +/-   ##
==========================================
- Coverage   87.60%   87.45%   -0.16%     
==========================================
  Files         335      335              
  Lines       12808    12812       +4     
  Branches     3532     3534       +2     
==========================================
- Hits        11221    11205      -16     
- Misses       1587     1607      +20     
Files with missing lines Coverage Δ
...onents/SelectInputFieldV2/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Chip/ChipContext.tsx 100.00% <ø> (ø)
...s/ui/src/components/DateInput/components/Popup.tsx 94.23% <ø> (ø)
...es/ui/src/components/List/__tests__/index.test.tsx 94.21% <100.00%> (-3.31%) ⬇️
packages/ui/src/components/NumberInput/index.tsx 96.21% <100.00%> (ø)
packages/ui/src/components/Popup/helpers.ts 82.94% <100.00%> (ø)
packages/ui/src/components/Popup/index.tsx 88.55% <100.00%> (ø)
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 43.75% <ø> (ø)
...ages/ui/src/components/SelectInputV2/SelectBar.tsx 64.49% <ø> (ø)
...c/components/SelectInputV2/SelectInputProvider.tsx 47.16% <ø> (ø)
... and 4 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcafecf...de468d7. Read the comment docs.

matthprost and others added 3 commits December 19, 2024 12:09
Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
@philibea philibea merged commit 293aa2c into main Dec 19, 2024
14 of 15 checks passed
@philibea philibea deleted the chore/react-19 branch December 19, 2024 11:33
@scaleway-bot scaleway-bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants