Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update key value button style #4581

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: update key value button style #4581

merged 2 commits into from
Dec 13, 2024

Conversation

Lawndlwd
Copy link
Member

@Lawndlwd Lawndlwd commented Dec 12, 2024

Summary

Type

  • Bug

Relevant logs and/or screenshots

Page Before After
url Screenshot 2024-12-12 at 17 50 09 Screenshot 2024-12-12 at 17 44 22
url screenshot screenshot

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 2f8359e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Lawndlwd Lawndlwd force-pushed the fix/key-value-style branch from bb5aa35 to 2f8359e Compare December 13, 2024 09:31
@Lawndlwd Lawndlwd enabled auto-merge (squash) December 13, 2024 09:31
@Lawndlwd Lawndlwd merged commit f783531 into main Dec 13, 2024
11 checks passed
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (de622a2) to head (2f8359e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4581      +/-   ##
==========================================
+ Coverage   87.58%   92.00%   +4.41%     
==========================================
  Files         335       65     -270     
  Lines       12804     1375   -11429     
  Branches     3485      206    -3279     
==========================================
- Hits        11215     1265    -9950     
+ Misses       1589      110    -1479     
Files with missing lines Coverage Δ
...ckages/form/src/components/KeyValueField/index.tsx 94.11% <ø> (ø)

... and 270 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b5d89...2f8359e. Read the comment docs.

@Lawndlwd Lawndlwd deleted the fix/key-value-style branch December 13, 2024 09:34
@scaleway-bot scaleway-bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants