Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all groups input to accept react node as legend #4584

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

<RadioGroup />, <SelectableCardGroup />, <CheckboxGroup /> and <ToggleGroup /> to accept ReactNode as legend type.

@matthprost matthprost added the enhancement New feature or request label Dec 13, 2024
@matthprost matthprost requested review from Lawndlwd and a team December 13, 2024 08:15
@matthprost matthprost self-assigned this Dec 13, 2024
@matthprost matthprost requested review from radhi-nasser-scaleway and removed request for a team December 13, 2024 08:15
@matthprost matthprost requested a review from lisalupi as a code owner December 13, 2024 08:15
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 1262ccb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (de622a2) to head (1262ccb).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4584   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         335      335           
  Lines       12804    12804           
  Branches     3485     3485           
=======================================
  Hits        11215    11215           
  Misses       1589     1589           
Files with missing lines Coverage Δ
packages/ui/src/components/CheckboxGroup/index.tsx 93.93% <ø> (ø)
packages/ui/src/components/RadioGroup/index.tsx 90.00% <ø> (ø)
...es/ui/src/components/SelectableCardGroup/index.tsx 96.77% <ø> (ø)
packages/ui/src/components/ToggleGroup/index.tsx 93.54% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b5d89...1262ccb. Read the comment docs.

@matthprost matthprost merged commit 4d8a5b5 into main Dec 18, 2024
14 checks passed
@matthprost matthprost deleted the fix/selectable-card-group-field branch December 18, 2024 10:41
@scaleway-bot scaleway-bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants