Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): use rem on icons #4602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(icons): use rem on icons #4602

wants to merge 2 commits into from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Feature

Summarise concisely:

What is expected?

Migrate icons on new rem size instead of px.

@matthprost matthprost added the enhancement New feature or request label Dec 19, 2024
@matthprost matthprost requested review from philibea and a team December 19, 2024 08:40
@matthprost matthprost self-assigned this Dec 19, 2024
@matthprost matthprost requested a review from lisalupi as a code owner December 19, 2024 08:40
@matthprost matthprost requested review from radhi-nasser-scaleway and removed request for a team December 19, 2024 08:40
Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 51bb702

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/icons Minor
@ultraviolet/plus Patch
@ultraviolet/ui Patch
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (4d8a5b5) to head (51bb702).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4602      +/-   ##
==========================================
- Coverage   87.60%   87.45%   -0.16%     
==========================================
  Files         335      335              
  Lines       12808    12812       +4     
  Branches     3532     3534       +2     
==========================================
- Hits        11221    11205      -16     
- Misses       1587     1607      +20     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcafecf...51bb702. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants