fixup post reviews

scality · Oct 15, 2024 · 1048e28 · 1048e28
1 parent 49b52c1
commit 1048e28
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/lib/api/BackbeatAPI.js b/lib/api/BackbeatAPI.js
@@ -1263,7 +1263,6 @@ class BackbeatAPI {
             if (this._config.queuePopulator.mongo) {
                 return this._setupLocationStatusManager(cb);
             } else {
-                this._logger.debug('BackbeatAPI setup ready without Mongo');
                 return cb();
             }
         });
@@ -1307,8 +1306,13 @@ class BackbeatAPI {
      * @returns {undefined} undefined
      */
     _setupMongoClient(cb) {
-        if (this._config.queuePopulator.mongo) {
-            const mongoConfig = this._config.queuePopulator.mongo;
+        const mongoConfig = this._config.queuePopulator.mongo;
+        if (!mongoConfig) {
+            this._logger.debug('MongoDB configuration not found, skipping MongoDB client setup', {
+                method: 'BackbeatAPI._setupMongoClient',
+            });
+            return cb();
+        } else {
             const mongoUrl = constructConnectionString(mongoConfig);
             return MongoClient.connect(mongoUrl, {
                 replicaSet: mongoConfig.replicaSet,
@@ -1331,11 +1335,6 @@ class BackbeatAPI {
                 });
                 return cb();
             });
-        } else {
-            this._logger.debug('MongoDB configuration not found, skipping MongoDB client setup', {
-                method: 'BackbeatAPI._setupMongoClient',
-            });
-            return cb();
         }
     }
 
@@ -1367,12 +1366,11 @@ class BackbeatAPI {
         return this._locationStatusManager._setupLocationStatusStore(err => {
             if (err) {
                 this._logger.error('error setting up location status manager', {
-                    method: 'BackbeatAPI.setupInternals',
+                    method: 'BackbeatAPI._setupLocationStatusManager',
                     error: err.message,
                 });
                 return cb(err);
             }
-            this._logger.info('BackbeatAPI setup ready');
             return cb();
         });
     }

diff --git a/tests/unit/api/BackbeatAPI.spec.js b/tests/unit/api/BackbeatAPI.spec.js
@@ -327,7 +327,6 @@ describe('BackbeatAPI', () => {
                 assert(setupMongoClientStub.calledOnce);
                 assert(setProducerStub.calledThrice);
                 assert(setupLocationStatusManagerStub.notCalled);
-                assert(debugSpy.calledWith('BackbeatAPI setup ready without Mongo'));
                 done();
             });
         });