Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB-362 remove kafka connect connector config from logs #2365

Merged
merged 2 commits into from
Feb 10, 2023
Merged

BB-362 remove kafka connect connector config from logs #2365

merged 2 commits into from
Feb 10, 2023

Conversation

Kerkesni
Copy link
Contributor

kafka connect connector config contains the mongodb connection string which should not be logged

also fixing a bug with the oplog populator where if a connector update fails cause the connector can't be found, it is not considered an error

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@Kerkesni Kerkesni changed the base branch from development/8.6 to development/8.4 February 10, 2023 16:34
@scality scality deleted a comment from bert-e Feb 10, 2023
@scality scality deleted a comment from bert-e Feb 10, 2023
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the bugfix/BB-362-fix-oplog-populator-mongo-creds-log branch from 9008c54 to f7575ac Compare February 10, 2023 16:52
@scality scality deleted a comment from bert-e Feb 10, 2023
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Feb 10, 2023
@scality scality deleted a comment from bert-e Feb 10, 2023
@scality scality deleted a comment from bert-e Feb 10, 2023
@scality scality deleted a comment from bert-e Feb 10, 2023
francoisferrand
francoisferrand reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Kerkesni Kerkesni force-pushed the bugfix/BB-362-fix-oplog-populator-mongo-creds-log branch from f7575ac to 906d490 Compare February 10, 2023 17:33
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Feb 10, 2023
@scality scality deleted a comment from bert-e Feb 10, 2023
@scality scality deleted a comment from bert-e Feb 10, 2023
@Kerkesni
BB-362 remove kafka connect connector config from logs
546e6a9 
kafka connect connector config contains the mongodb connection string
which should not be logged
@Kerkesni
BB-362 fix oplog populator not retrying to update connector when conn…
ec059dd 
…ector is not found

fixing a bug with the oplog populator where if a connector update
fails cause the connector can't be found, it is not considered an error
and the update is not retried later
@Kerkesni Kerkesni force-pushed the bugfix/BB-362-fix-oplog-populator-mongo-creds-log branch from 906d490 to ec059dd Compare February 10, 2023 17:45
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

History mismatch

Merge commit #ffe55021cc8582770d904e030b450e8022a5ff2e on the integration branch
w/8.5/bugfix/BB-362-fix-oplog-populator-mongo-creds-log is merging a branch which is neither the current
branch bugfix/BB-362-fix-oplog-populator-mongo-creds-log nor the development branch
development/8.5.

It is likely due to a rebase of the branch bugfix/BB-362-fix-oplog-populator-mongo-creds-log and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@Kerkesni
Copy link
Contributor Author

/force_reset

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/8.3

Please check the status of the associated issue BB-362.

Goodbye kerkesni.

@bert-e bert-e merged commit ec059dd into development/8.4 Feb 10, 2023
@bert-e bert-e deleted the bugfix/BB-362-fix-oplog-populator-mongo-creds-log branch February 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillianG KillianG KillianG approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kerkesni @bert-e @francoisferrand @KillianG