Ensure _getBackbeatClient Always Returns BackbeatMetadataProxy

[nicolas2bert]

The _getBackbeatClient function from the BucketProcessor should consistently return an instance of BackbeatMetadataProxy. However, there is an issue in the code where the function returns an instance of BackbeatClient when caching.

Impact:

• Ring S3C: no direct impact today, since backbeatClient is only used for "lifecycle Transition workflow" that has been backported but is not supported yet. However, the inconstant result of _getBackbeatClient blocks additional development such as “lifecycle listing optimization “.

• Artesca: no impact since the logic has been fixed already with the ClientManager: https://github.com/scality/backbeat/blob/development/8.7/lib/clients/ClientManager.js

Note: the getBackbeatClient from the ObjectProcessor is correctly implemented.

[bert-e]

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-431 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 7.10.13

• 7.70.4

• 8.5.5

• 8.6.27

• 8.7.0

Please check the Fix Version/s of BB-431, or the target
branch of this pull request.

[nicolas2bert]

ping

[bert-e]

Conflict

A conflict has been raised during the creation of
integration branch w/8.5/bugfix/BB-431/get-backbeat-client with contents from w/7.70/bugfix/BB-431/get-backbeat-client
and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.5/bugfix/BB-431/get-backbeat-client origin/development/8.5
 $ git merge origin/w/7.70/bugfix/BB-431/get-backbeat-client
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.5/bugfix/BB-431/get-backbeat-client

[bert-e]

Conflict

A conflict has been raised during the creation of
integration branch w/8.6/bugfix/BB-431/get-backbeat-client with contents from w/8.5/bugfix/BB-431/get-backbeat-client
and development/8.6.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.6/bugfix/BB-431/get-backbeat-client origin/development/8.6
 $ git merge origin/w/8.5/bugfix/BB-431/get-backbeat-client
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.6/bugfix/BB-431/get-backbeat-client

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge bugfix/BB-431/get-backbeat-client into
  development/7.10
• w/7.70/bugfix/BB-431/get-backbeat-client will be merged into development/7.70
• w/8.5/bugfix/BB-431/get-backbeat-client will be merged into development/8.5
• w/8.6/bugfix/BB-431/get-backbeat-client will be merged into development/8.6
• w/8.7/bugfix/BB-431/get-backbeat-client will be merged into development/8.7

The following branches will NOT be impacted:

• development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[nicolas2bert]

@bert-e approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/7.10

• ✔️ development/7.70

• ✔️ development/8.5

• ✔️ development/8.6

• ✔️ development/8.7

The following branches will NOT be impacted:

• development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/7.10

• ✔️ development/7.70

• ✔️ development/8.5

• ✔️ development/8.6

• ✔️ development/8.7

The following branches have NOT changed:

• development/7.4

Please check the status of the associated issue BB-431.

Goodbye nicolas2bert.