Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket-processor: add timeout on s3 client #2452

Merged
merged 2 commits into from
Oct 16, 2023
Merged

bucket-processor: add timeout on s3 client #2452

merged 2 commits into from
Oct 16, 2023

Conversation

francoisferrand
Copy link
Contributor

  • Add timeout on s3 client
  • Add timeout on management s3 client

Issue: BB-445

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2023

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@francoisferrand francoisferrand changed the base branch from development/8.6 to improvement/BB-439 October 13, 2023 04:48
@scality scality deleted a comment from bert-e Oct 13, 2023
@francoisferrand
Add timeout on s3 client
b7a8c19 
A timeout is needed to ensure backbeat does not get "block" indefinitely
in case of hardware failure or software bug.

This can cause backbeat services (bucket-processor in that case) to stop
consuming any Kafka message.

Issue: BB-444
@francoisferrand
Add timeout on management s3 client
09a7124 
Issue: BB-444
@francoisferrand
Copy link
Contributor Author

/approve

Base automatically changed from improvement/BB-439 to development/8.6 October 16, 2023 09:18
@bert-e
Copy link
Contributor

bert-e commented Oct 16, 2023

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/BB-445 into
    development/8.6
  • w/8.7/bugfix/BB-445 will be merged into development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 16, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 16, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

Please check the status of the associated issue BB-445.

Goodbye francoisferrand.

@bert-e bert-e merged commit f5872a8 into development/8.6 Oct 16, 2023
4 checks passed
@bert-e bert-e deleted the bugfix/BB-445 branch October 16, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillianG KillianG KillianG approved these changes

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoisferrand @bert-e @jonathan-gramain @KillianG