Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-451: Add fallback timestamp to delete notifications #2453

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

rachedbenmustapha
Copy link
Contributor

Delete notification events were missing the eventTime attribute because the last-modified MD field was not present in the raft log. This change uses the raft log entries' timestamp attribute in its place for delete operations.

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

Hello rachedbenmustapha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

Incorrect fix version

The Fix Version/s in issue BB-451 contains:

  • 7.70.7

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.70.7

  • 8.5.5

  • 8.6.29

  • 8.7.0

Please check the Fix Version/s of BB-451, or the target
branch of this pull request.

@rachedbenmustapha rachedbenmustapha force-pushed the feature/BB-451-delete-notification-fields branch from 2578db9 to e12d058 Compare October 13, 2023 16:43
@rachedbenmustapha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

Conflict

A conflict has been raised during the creation of
integration branch w/8.5/feature/BB-451-delete-notification-fields with contents from feature/BB-451-delete-notification-fields
and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.5/feature/BB-451-delete-notification-fields origin/development/8.5
 $ git merge origin/feature/BB-451-delete-notification-fields
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.5/feature/BB-451-delete-notification-fields

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

Build failed

The build for commit did not succeed in branch w/8.7/feature/BB-451-delete-notification-fields.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.70

  • ✔️ development/8.5

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.70

  • ✔️ development/8.5

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4

Please check the status of the associated issue BB-451.

Goodbye rachedbenmustapha.

@bert-e bert-e merged commit e12d058 into development/7.70 Oct 13, 2023
3 checks passed
@bert-e bert-e deleted the feature/BB-451-delete-notification-fields branch October 13, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants