-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward system signals to the node process using tini #2457
Conversation
npm run doesn’t handle signal forwarding and crashes on the SIGTERM signal sent by Kubernetes. Tini spawns a process at PID 1 that handles forwarding system signals to all it's child processes. Issur: BB-459
Hello kerkesni,My role is to assist you with the merge of this Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-459. Goodbye kerkesni. |
npm run
doesn’t handle signal forwarding and crashes on the SIGTERM signal sent by Kubernetes.This prevents backbeat from doing a cleanup before shutting down.
We'll use
Tini
, which spawns a process at PID 1 that handles forwarding system signals to all it's child processes.This is the recommended solution found in the NodeJS best practicing guide.
Issur: BB-459