-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete & commit current task(s) on rebalance #2463
Conversation
The purpose of bootstrap is to ensure the consumer receives next messages: i.e. that the offset is already stored, so that we get every later message. For this to work, the offset needs to be comitted: since however we are not using the `auto.offset.store`, we must manually store the offset. Issue: BB-441
Hello francoisferrand,My role is to assist you with the merge of this Status report is not available. |
This should ensure the offsets are stored (and commited) on rebalance. Issue: BB-441
The tests used to run setup hooks in parallel, so both consumers could "see" the bootstrap message, causing the test to fail. Also, we need to push some messages: otherwise we cannot see that breakbeat is really "blocking" the consumption. Issue: BB-441
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
237992b
to
4093ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No question to ask in the end, the code answered it itself!
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-441. Goodbye francoisferrand. |
Implement rebalance callback, so that we will now properly handle the rebalance process at
application level, and thus avoid extra rebalances or processing the same entry multiple times:
unassign
, wait until current tasks are complete, by draining the queue;auto-commit timer, which may happen at any time in the process)
rebalance.
We are expected (by kafka) to do this whole process within
max.poll.interval.ms
(default 5min),similar to how we are expected to poll periodically. This should be fine in general, except in case
of a bug where a task is really stuck. In that case, the consumer will get kicked out of the
cluster, and commit may fail. If tasks eventually unblock, the consumer will reconnect to the
cluster on next call to
consume()
, which will trigger a rebalance. There is no guard yet againstthis, and we keep the same behavior as before in those cases.
Issue: BB-441