-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move restore-expiration processing to transition processor #2467
Conversation
b2e61f4
to
2c31485
Compare
3f1111a
to
33ffb08
Compare
The conductor checks the lag of the object-processor to detect if the previous lifecycle listing has been processed, i.e. status has been persisted for all triggered operations. Consequently it must check the bucket-processor lag (e.g. is listing terminated), but also the data-mover topic (for transitions) and object- processor (for expirations). It may check the cold-archive topics, but it is not needed since the object is immediately updated with a "transition in process" flag. However, it must not check topics/consumers which are not directly linked to the lifecycle listing: in particular the transition-processor, which handles the end of transitions (update status, requeue...). To be consistent and avoid unexpected throtlling, restored object expiration messages must be ignored by the conductor: hence we move processing to the transition processor. Issue: BB-449
33ffb08
to
bd08103
Compare
2c31485
to
6f4f991
Compare
/approve |
Hello francoisferrand,My role is to assist you with the merge of this Status report is not available. |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-449. Goodbye francoisferrand. |
The conductor checks the lag of the object-processor to detect if the previous lifecycle listing has been processed, i.e. status has been persisted for all triggered operations.
Consequently it must check the bucket-processor lag (e.g. is listing terminated), but also the data-mover topic (for transitions) and object- processor (for expirations). It may check the cold-archive topics, but it is not needed since the object is immediately updated with a "transition in process" flag.
However, it must not check topics/consumers which are not directly linked to the lifecycle listing: in particular the transition-processor, which handles the end of transitions (update status, requeue...).
To be consistent and avoid unexpected throtlling, restored object expiration messages must be ignored by the conductor: hence we move processing to the transition processor.
Issue: BB-449