Fix BackbeatProducer event.error handlers set twice.

[benzekrimaha]

Issue : BB-523

[bert-e]

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-523 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.7.0

Please check the Fix Version/s of BB-523, or the target
branch of this pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (0a3aa3c) to head (92520d5).
Report is 1 commits behind head on development/8.7.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/BackbeatProducer.js	89.18% <100.00%> (+3.60%)	⬆️

... and 1 file with indirect coverage changes

Components	Coverage Δ
Bucket Notification	66.66% <ø> (ø)
Core Library	74.13% <100.00%> (+0.05%)	⬆️
Ingestion	68.70% <ø> (ø)
Lifecycle	74.92% <ø> (ø)
Oplog Populator	82.95% <ø> (ø)
Replication	57.42% <ø> (ø)
Bucket Scanner	85.76% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/8.7    #2535      +/-   ##
===================================================
+ Coverage            69.37%   69.40%   +0.02%     
===================================================
  Files                  194      194              
  Lines                12792    12792              
===================================================
+ Hits                  8875     8878       +3     
+ Misses                3907     3904       -3     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.66% <0.00%> (-0.01%)	⬇️
api:routes	9.56% <0.00%> (-0.01%)	⬇️
bucket-scanner	85.76% <ø> (ø)
ingestion	12.47% <0.00%> (-0.01%)	⬇️
lib	7.55% <0.00%> (-0.02%)	⬇️
lifecycle	19.39% <0.00%> (-0.01%)	⬇️
notification	0.88% <0.00%> (ø)
replication	18.96% <0.00%> (-0.01%)	⬇️
unit	43.01% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[francoisferrand]

i think this is more subtle than this.

we set 2 event handlers (which is fine) : this one for logs, always ; the other one to emit an error (but also log) only from a certain point in the state machine

→ we propably want to avoid the duplicate logs, but we still want to have the logs all the time ; without changing the current logic of the automaton...

[benzekrimaha]

Went for a flag to avoid duplicate logs here: 82315d2

[benzekrimaha]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.7

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.5
• development/8.6

Please check the status of the associated issue BB-523.

Goodbye benzekrimaha.

The following options are set: approve