Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication deployment with single location per instance #2537

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Sep 6, 2024

Issue : BB-495

@bert-e
Copy link
Contributor

bert-e commented Sep 6, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch 4 times, most recently from 3e34a28 to 8563228 Compare September 13, 2024 15:00
@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch 6 times, most recently from ab9a15e to 811702b Compare September 17, 2024 09:02
@benzekrimaha benzekrimaha marked this pull request as ready for review September 17, 2024 09:02
@scality scality deleted a comment from bert-e Sep 17, 2024
@scality scality deleted a comment from codecov bot Sep 17, 2024
@bert-e
Copy link
Contributor

bert-e commented Sep 17, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (d886d22) to head (0a3aa3c).
Report is 2 commits behind head on development/8.7.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 64.70% <100.00%> (+1.22%) ⬆️

... and 1 file with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.07% <100.00%> (+0.03%) ⬆️
Ingestion 68.70% <ø> (ø)
Lifecycle 74.92% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.42% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/8.7    #2537      +/-   ##
===================================================
+ Coverage            69.36%   69.37%   +0.01%     
===================================================
  Files                  194      194              
  Lines                12788    12792       +4     
===================================================
+ Hits                  8870     8875       +5     
+ Misses                3908     3907       -1     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.67% <75.00%> (+0.02%) ⬆️
api:routes 9.57% <75.00%> (+0.02%) ⬆️
bucket-scanner 85.76% <ø> (ø)
ingestion 12.48% <75.00%> (+0.02%) ⬆️
lib 7.57% <75.00%> (+0.02%) ⬆️
lifecycle 19.40% <75.00%> (+0.01%) ⬆️
notification 0.88% <0.00%> (-0.01%) ⬇️
replication 18.97% <75.00%> (+0.01%) ⬆️
unit 42.97% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@benzekrimaha benzekrimaha changed the title wip Replication deployment with single location per instance Sep 17, 2024
lib/Config.js Outdated
@@ -82,6 +82,9 @@ class Config extends EventEmitter {
this.bootstrapList = [];
}

if (process.env.SITE_NAME) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the environment variable should better explain what it does exactly (if I understand correctly, we want to restrict the list of locations to be managed, so we could have something like MANAGED_SITE_NAME (but please challenge that)

lib/Config.js Outdated Show resolved Hide resolved
tests/unit/conf/Config.js Outdated Show resolved Hide resolved
@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch 5 times, most recently from 7c39875 to 75f00fd Compare September 18, 2024 14:24
lib/Config.js Outdated Show resolved Hide resolved
lib/Config.js Outdated Show resolved Hide resolved
@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch 2 times, most recently from f66b98f to 0286565 Compare September 18, 2024 17:55
@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch 2 times, most recently from af84d02 to d799053 Compare September 18, 2024 18:25
@@ -36,6 +36,7 @@ class Config extends EventEmitter {
* By default, the config file is "config.json" at the root.
* It can be overridden using the BACKBEAT_CONFIG_FILE environment var.
*/
this.Config = Config;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a small comment to explain why this was added ?

@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch from d799053 to 4647cc9 Compare September 19, 2024 13:32
@benzekrimaha benzekrimaha force-pushed the improvement/BB-495-replication-deployment-with-single-location branch from 6cb2c30 to 0a3aa3c Compare September 20, 2024 12:29
@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 20, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-495.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 0a3aa3c into development/8.7 Sep 20, 2024
9 checks passed
@bert-e bert-e deleted the improvement/BB-495-replication-deployment-with-single-location branch September 20, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants