Improvement/bb 514 handle lifecycle rules

[benzekrimaha]

Issue : BB-514

[bert-e]

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-514 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.7.0

Please check the Fix Version/s of BB-514, or the target
branch of this pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (782c479) to head (1540d41).
Report is 2 commits behind head on development/8.7.

Additional details and impacted files

Files with missing lines	Coverage Δ
extensions/lifecycle/LifecycleConfigValidator.js	85.71% <100.00%> (+2.38%)	⬆️
...ecycle/bucketProcessor/LifecycleBucketProcessor.js	79.48% <100.00%> (ø)
extensions/lifecycle/tasks/LifecycleTask.js	89.39% <100.00%> (-0.02%)	⬇️
extensions/lifecycle/util/rules.js	100.00% <100.00%> (ø)
lib/config/configItems.joi.js	96.15% <ø> (ø)
lib/constants.js	100.00% <ø> (ø)

Components	Coverage Δ
Bucket Notification	66.66% <ø> (ø)
Core Library	75.12% <ø> (ø)
Ingestion	69.24% <ø> (ø)
Lifecycle	76.20% <100.00%> (-0.01%)	⬇️
Oplog Populator	82.95% <ø> (ø)
Replication	57.57% <ø> (ø)
Bucket Scanner	85.60% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/8.7    #2548      +/-   ##
===================================================
- Coverage            70.29%   70.28%   -0.01%     
===================================================
  Files                  194      194              
  Lines                12966    12965       -1     
===================================================
- Hits                  9114     9113       -1     
  Misses                3842     3842              
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.75% <25.00%> (+<0.01%)	⬆️
api:routes	9.56% <25.00%> (+<0.01%)	⬆️
bucket-scanner	85.60% <ø> (ø)
ingestion	12.48% <25.00%> (+<0.01%)	⬆️
lib	7.52% <25.00%> (+<0.01%)	⬆️
lifecycle	19.28% <100.00%> (-0.01%)	⬇️
notification	0.88% <0.00%> (+<0.01%)	⬆️
replication	18.90% <25.00%> (+<0.01%)	⬆️
unit	46.68% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[francoisferrand]

we may also want to validate each item from this list : i.e. to ensure each value is indeed of the potentially supported rule type

[benzekrimaha]

done here : 1d60534#diff-4ddf07d1cd40d3d68a85bcf7ab41f36f43094af8cfc0e93424067c48bd03b623R70-R78

[KillianG]

we might also want to add the new field to conf/config.json no ?

[benzekrimaha]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.7

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.5
• development/8.6

Please check the status of the associated issue BB-514.

Goodbye benzekrimaha.

The following options are set: approve