Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow consuming log records without wait when more logs are available #2557

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Kerkesni
Copy link
Contributor

The cooldown between batches is removed when more logs are available to consume.

This is mostly needed for S3C to keep good replication rates.

Issue: BB-532

@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (a1533a4) to head (6438b93).
Report is 1 commits behind head on development/8.7.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/config.joi.js 100.00% <ø> (ø)
lib/queuePopulator/LogReader.js 54.54% <100.00%> (+13.73%) ⬆️
lib/queuePopulator/QueuePopulator.js 35.55% <100.00%> (+2.67%) ⬆️
Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 75.03% <100.00%> (+0.74%) ⬆️
Ingestion 69.24% <ø> (ø)
Lifecycle 76.07% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.42% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/8.7    #2557      +/-   ##
===================================================
+ Coverage            69.88%   70.19%   +0.31%     
===================================================
  Files                  194      194              
  Lines                12922    12931       +9     
===================================================
+ Hits                  9030     9077      +47     
+ Misses                3882     3844      -38     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.63% <0.00%> (-0.01%) ⬇️
api:routes 9.53% <0.00%> (-0.01%) ⬇️
bucket-scanner 85.60% <ø> (ø)
ingestion 12.48% <0.00%> (-0.01%) ⬇️
lib 7.51% <0.00%> (-0.01%) ⬇️
lifecycle 19.30% <0.00%> (+<0.01%) ⬆️
notification 0.88% <0.00%> (-0.01%) ⬇️
replication 18.87% <0.00%> (-0.02%) ⬇️
unit 45.57% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@scality scality deleted a comment from bert-e Oct 15, 2024
@Kerkesni Kerkesni force-pushed the improvement/BB-532 branch 2 times, most recently from ab16290 to 4a93e99 Compare October 22, 2024 09:12
@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 22, 2024

Conflict with a changeset in the queue

The changeset in this pull request conflicts with another changeset
already in the queue. Please wait for the current queue to merge into
the development branch. The conflict will then appear in this pull
request and can be sorted on the feature branch directly.

This changeset has not been added to the queue.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 22, 2024

Conflict

There is a conflict between your branch improvement/BB-532 and the
destination branch development/8.7.

Please resolve the conflict on the feature branch (improvement/BB-532).

git fetch && \
git checkout origin/improvement/BB-532 && \
git merge origin/development/8.7

Resolve merge conflicts and commit

git push origin HEAD:improvement/BB-532

The following options are set: approve

The cooldown between batches is removed when more logs are available
to consume.

This is mostly needed for S3C to keep good replication rates.

Issue: BB-532
@bert-e
Copy link
Contributor

bert-e commented Oct 22, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-532.

Goodbye kerkesni.

The following options are set: approve

@bert-e bert-e merged commit 6438b93 into development/8.7 Oct 22, 2024
9 checks passed
@bert-e bert-e deleted the improvement/BB-532 branch October 22, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants