-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dataMoverTopic config param always being required #2572
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 2 files with indirect coverage changes
@@ Coverage Diff @@
## development/8.7 #2572 +/- ##
===================================================
+ Coverage 70.40% 70.42% +0.01%
===================================================
Files 194 194
Lines 12996 13001 +5
===================================================
+ Hits 9150 9156 +6
+ Misses 3836 3835 -1
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Extension configs are validated independently of each other, so validating the dataMoverTopic based on the supportedLifecycleRules param is not currently possible. Issue: BB-619
004331a
to
2a0e326
Compare
beforeEach(() => { | ||
config = new Config(); | ||
// deep copy the config to avoid modifying the original | ||
testConfig = JSON.parse(JSON.stringify(backbeatConfig)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
testConfig = JSON.parse(JSON.stringify(backbeatConfig)); | |
testConfig = { ...backbeatConfig }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ ...backbeatConfig }
doesn't deep copy nested objets.
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-619. Goodbye kerkesni. |
Extension configs are validated independently of each other, so validating the dataMoverTopic based on the supportedLifecycleRules param is not currently possible.
Issue: BB-619