Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION [PR#2574 > development/8.6] Bugfix/bb 624 connection retry #2579

Closed
wants to merge 13 commits into from

Conversation

bert-e
Copy link
Contributor

@bert-e bert-e commented Nov 5, 2024

This pull request has been created automatically.
It is linked to its parent pull request #2574.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.6/bugfix/BB-624-connection-retry, please follow this
procedure:

 $ git fetch
 $ git checkout w/8.6/bugfix/BB-624-connection-retry
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/8.6/bugfix/BB-624-connection-retry

Please always comment pull request #2574 instead of this one.

BourgoisMickael and others added 13 commits November 4, 2024 15:04
Missing from S3C-9338 because this usage of
sdk doesn't use the env variable
Prevent hanging indefinitely if replication status' BackbeatConsumer
succeeds to connect to kafka but then FailedCRRPRoducer or
ReplayProducer fails
If probing too soon on startup some components
can crash. The probe server is started after the queue
…retry' into w/8.5/bugfix/BB-624-connection-retry

Discard some changes from S3C
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (0a32e66) to head (c08f0dc).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/queuePopulator.js 0.00% <ø> (ø)
...ensions/replication/failedCRR/FailedCRRProducer.js 80.95% <ø> (-0.87%) ⬇️
extensions/replication/replay/ReplayProducer.js 15.78% <ø> (+0.78%) ⬆️
lib/clients/BackbeatClient.js 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.02% <ø> (ø)
Ingestion 68.70% <ø> (ø)
Lifecycle 75.00% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.43% <ø> (+<0.01%) ⬆️
Bucket Scanner 85.60% <ø> (-0.16%) ⬇️
@@                 Coverage Diff                 @@
##           development/8.6    #2579      +/-   ##
===================================================
+ Coverage            69.37%   69.47%   +0.09%     
===================================================
  Files                  194      194              
  Lines                12791    12861      +70     
===================================================
+ Hits                  8874     8935      +61     
- Misses                3907     3916       +9     
  Partials                10       10              
Flag Coverage Δ
bucket-scanner 85.60% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@bert-e bert-e closed this Nov 6, 2024
@bert-e bert-e deleted the w/8.6/bugfix/BB-624-connection-retry branch November 6, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants