-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTEGRATION [PR#2574 > development/8.6] Bugfix/bb 624 connection retry #2579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing from S3C-9338 because this usage of sdk doesn't use the env variable
Will be improved in S3C-9479
(cherry picked from commit 101af70)
(cherry picked from commit 22282ac)
(cherry picked from commit 3c2aa76)
…/bugfix/BB-624-connection-retry
Prevent hanging indefinitely if replication status' BackbeatConsumer succeeds to connect to kafka but then FailedCRRPRoducer or ReplayProducer fails
If probing too soon on startup some components can crash. The probe server is started after the queue
…/bugfix/BB-624-connection-retry
…retry' into w/8.5/bugfix/BB-624-connection-retry Discard some changes from S3C
…w/8.6/bugfix/BB-624-connection-retry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 5 files with indirect coverage changes
@@ Coverage Diff @@
## development/8.6 #2579 +/- ##
===================================================
+ Coverage 69.37% 69.47% +0.09%
===================================================
Files 194 194
Lines 12791 12861 +70
===================================================
+ Hits 8874 8935 +61
- Misses 3907 3916 +9
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #2574.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.6/bugfix/BB-624-connection-retry
, please follow thisprocedure:
$ git fetch $ git checkout w/8.6/bugfix/BB-624-connection-retry $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.6/bugfix/BB-624-connection-retry
Please always comment pull request #2574 instead of this one.