salt: use all etcd servers as apiserver backends #2181

alexandre-allard · 2020-01-10T09:37:56Z

Component: salt, apiserver

Context:
Until now, we only use the local etcd as the apiserver backend

Summary:
Define all clients URLs as etcd servers for API server backend, this way, if the local etcd is
down, the API server is still able to answer.

Acceptance criteria: Green build

Closes: #2080

bert-e · 2020-01-10T09:37:58Z

Hello alexandre-allard-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2020-01-10T09:38:05Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2080-kas-on-local-etcd into
development/2.4
w/2.5/bugfix/2080-kas-on-local-etcd will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-01-10T09:38:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2020-01-10T10:13:39Z

History mismatch

Merge commit #1234af47f338186079d504f618b96f782ae202f8 on the integration branch
w/2.5/bugfix/2080-kas-on-local-etcd is merging a branch which is neither the current
branch bugfix/2080-kas-on-local-etcd nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/2080-kas-on-local-etcd and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

alexandre-allard · 2020-01-10T10:35:56Z

/reset

bert-e · 2020-01-10T10:36:04Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2020-01-10T10:36:12Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2080-kas-on-local-etcd into
development/2.4
w/2.5/bugfix/2080-kas-on-local-etcd will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-01-10T10:36:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2020-01-10T11:14:19Z

History mismatch

Merge commit #f7b8c9c6b8741bae45e2dde49c54382b63964e29 on the integration branch
w/2.5/bugfix/2080-kas-on-local-etcd is merging a branch which is neither the current
branch bugfix/2080-kas-on-local-etcd nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/2080-kas-on-local-etcd and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

alexandre-allard · 2020-01-10T13:19:16Z

/reset

bert-e · 2020-01-10T13:19:23Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2020-01-10T13:19:31Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2080-kas-on-local-etcd into
development/2.4
w/2.5/bugfix/2080-kas-on-local-etcd will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-01-10T13:19:33Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

salt/metalk8s/kubernetes/apiserver/installed.sls

bert-e · 2020-01-20T09:06:12Z

History mismatch

Merge commit #20cfe2b5101a348097c70d1e9bdd470e37abfbed on the integration branch
w/2.5/bugfix/2080-kas-on-local-etcd is merging a branch which is neither the current
branch bugfix/2080-kas-on-local-etcd nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/2080-kas-on-local-etcd and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

salt/metalk8s/kubernetes/apiserver/installed.sls

TeddyAndrieux

LGTM

alexandre-allard · 2020-01-20T10:43:09Z

/reset

bert-e · 2020-01-20T10:43:17Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2020-01-20T10:43:26Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2080-kas-on-local-etcd into
development/2.4
w/2.5/bugfix/2080-kas-on-local-etcd will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-01-20T10:43:28Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Define all clients URLs as etcd servers for API server backend, this way, if the local etcd is down, the API server is still able to answer. Set the local etcd, if any, as the first member in the list. Refs: #2080

bert-e · 2020-01-23T08:29:55Z

History mismatch

Merge commit #fb17a59dda748509be49b442f1932b3f8d52ba22 on the integration branch
w/2.5/bugfix/2080-kas-on-local-etcd is merging a branch which is neither the current
branch bugfix/2080-kas-on-local-etcd nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/2080-kas-on-local-etcd and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

alexandre-allard · 2020-01-23T08:30:00Z

/reset

bert-e · 2020-01-23T08:30:08Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2020-01-23T08:30:17Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2080-kas-on-local-etcd into
development/2.4
w/2.5/bugfix/2080-kas-on-local-etcd will be merged into development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-01-23T08:30:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

alexandre-allard · 2020-01-23T08:30:23Z

/approve

bert-e · 2020-01-23T08:30:32Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

gdemonet · 2020-01-23T14:36:43Z

salt/metalk8s/kubernetes/apiserver/installed.sls

+{%- set etcd_servers = [] %}
+{#- NOTE: Filter out members with empty name as they are not started yet. #}
+{%- for member in pillar.metalk8s.etcd.members | selectattr('name') %}
+{%-   do etcd_servers.extend(member['client_urls']) %}
+{%- endfor %}
+{%- set etcd_servers = etcd_servers | sort %}


If you like Jinja tricks:

{%- set etcd_servers = pillar.metalk8s.etcd.members | selectattr('name') | sum(attribute='client_urls', start=[]) | sort %}

bert-e · 2020-01-23T14:37:16Z

Build failed

The build for commit did not succeed in branch bugfix/2080-kas-on-local-etcd.

The following options are set: approve

bert-e · 2020-01-23T17:15:54Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.4
✔️ development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2020-01-24T09:13:05Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.4
✔️ development/2.5

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

alexandre-allard requested a review from a team as a code owner January 10, 2020 09:37

alexandre-allard force-pushed the bugfix/2080-kas-on-local-etcd branch from 1234af4 to e31f53b Compare January 10, 2020 10:13

alexandre-allard force-pushed the bugfix/2080-kas-on-local-etcd branch from e31f53b to f7b8c9c Compare January 10, 2020 10:15

alexandre-allard force-pushed the bugfix/2080-kas-on-local-etcd branch from f7b8c9c to 20cfe2b Compare January 10, 2020 11:14

piratos reviewed Jan 10, 2020

View reviewed changes

salt/metalk8s/kubernetes/apiserver/installed.sls Outdated Show resolved Hide resolved

alexandre-allard force-pushed the bugfix/2080-kas-on-local-etcd branch from 20cfe2b to ca15d95 Compare January 20, 2020 09:06

TeddyAndrieux reviewed Jan 20, 2020

View reviewed changes

salt/metalk8s/kubernetes/apiserver/installed.sls Outdated Show resolved Hide resolved

alexandre-allard force-pushed the bugfix/2080-kas-on-local-etcd branch from ca15d95 to fb17a59 Compare January 20, 2020 10:32

TeddyAndrieux previously approved these changes Jan 20, 2020

View reviewed changes

salt: use all etcd servers as apiserver backends

bb84b6a

Define all clients URLs as etcd servers for API server backend, this way, if the local etcd is down, the API server is still able to answer. Set the local etcd, if any, as the first member in the list. Refs: #2080

alexandre-allard dismissed TeddyAndrieux’s stale review via bb84b6a January 23, 2020 08:29

alexandre-allard force-pushed the bugfix/2080-kas-on-local-etcd branch from fb17a59 to bb84b6a Compare January 23, 2020 08:29

gdemonet approved these changes Jan 23, 2020

View reviewed changes

bert-e merged commit bb84b6a into development/2.4 Jan 24, 2020

bert-e deleted the bugfix/2080-kas-on-local-etcd branch January 24, 2020 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

salt: use all etcd servers as apiserver backends #2181

salt: use all etcd servers as apiserver backends #2181

alexandre-allard commented Jan 10, 2020 •

edited

Loading

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

alexandre-allard commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

alexandre-allard commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 10, 2020

bert-e commented Jan 20, 2020

TeddyAndrieux left a comment

alexandre-allard commented Jan 20, 2020

bert-e commented Jan 20, 2020

bert-e commented Jan 20, 2020

bert-e commented Jan 20, 2020

bert-e commented Jan 23, 2020

alexandre-allard commented Jan 23, 2020

bert-e commented Jan 23, 2020

bert-e commented Jan 23, 2020

bert-e commented Jan 23, 2020

alexandre-allard commented Jan 23, 2020

bert-e commented Jan 23, 2020

gdemonet Jan 23, 2020

bert-e commented Jan 23, 2020

bert-e commented Jan 23, 2020

bert-e commented Jan 24, 2020

salt: use all etcd servers as apiserver backends #2181

salt: use all etcd servers as apiserver backends #2181

Conversation

alexandre-allard commented Jan 10, 2020 • edited Loading

bert-e commented Jan 10, 2020

Hello alexandre-allard-scality,

bert-e commented Jan 10, 2020

Integration data created

bert-e commented Jan 10, 2020

Waiting for approval

bert-e commented Jan 10, 2020

History mismatch

alexandre-allard commented Jan 10, 2020

bert-e commented Jan 10, 2020

Reset complete

bert-e commented Jan 10, 2020

Integration data created

bert-e commented Jan 10, 2020

Waiting for approval

bert-e commented Jan 10, 2020

History mismatch

alexandre-allard commented Jan 10, 2020

bert-e commented Jan 10, 2020

Reset complete

bert-e commented Jan 10, 2020

Integration data created

bert-e commented Jan 10, 2020

Waiting for approval

bert-e commented Jan 20, 2020

History mismatch

TeddyAndrieux left a comment

Choose a reason for hiding this comment

alexandre-allard commented Jan 20, 2020

bert-e commented Jan 20, 2020

Reset complete

bert-e commented Jan 20, 2020

Integration data created

bert-e commented Jan 20, 2020

Waiting for approval

bert-e commented Jan 23, 2020

History mismatch

alexandre-allard commented Jan 23, 2020

bert-e commented Jan 23, 2020

Reset complete

bert-e commented Jan 23, 2020

Integration data created

bert-e commented Jan 23, 2020

Waiting for approval

alexandre-allard commented Jan 23, 2020

bert-e commented Jan 23, 2020

Waiting for approval

gdemonet Jan 23, 2020

Choose a reason for hiding this comment

bert-e commented Jan 23, 2020

Build failed

bert-e commented Jan 23, 2020

In the queue

bert-e commented Jan 24, 2020

alexandre-allard commented Jan 10, 2020 •

edited

Loading