Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify redis client and handle redis errors #9

Closed
rahulreddy opened this issue Aug 17, 2016 · 0 comments
Closed

Unify redis client and handle redis errors #9

rahulreddy opened this issue Aug 17, 2016 · 0 comments
Labels

Comments

@rahulreddy
Copy link
Collaborator

UtapiClient currently does not listen to the redis error event, which may flood the logs when Redis
server is unavailable.
This also calls for unification of the redis client as we want the configuration to be setup in one place for easier maintenance.
Lastly, we want to remove the offline queue option, since there is no limit on the callback queue, it may grow to infinity resulting in a RangeError. This option can be re-introduced later after this PR on ioredis is merged, which gives the developer an option to manage the offline queue
redis/ioredis#241

@rahulreddy rahulreddy added the bug label Aug 17, 2016
rahulreddy added a commit that referenced this issue Aug 17, 2016
Fix #9

This commit offers a cleanup to use unify the redis client usage
and add an error handler to handle redis connection errors. The option
for offline queue has been removed (for now) as it may grow the callback
queue to infinity and eventually result in a RangeError.
rahulreddy added a commit that referenced this issue Aug 17, 2016
Fix #9

This commit offers a cleanup to unify the redis client usage
and add an error handler to handle redis connection errors. The option
for offline queue has been removed (for now) as it may grow the callback
queue to infinity and eventually result in a RangeError.
rahulreddy added a commit that referenced this issue Aug 17, 2016
Fix #9

This commit offers a cleanup to unify the redis client usage
and add an error handler to handle redis connection errors. The option
for offline queue has been removed (for now) as it may grow the callback
queue to infinity and eventually result in a RangeError.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant