DSET-4430: Test also Go 1.20 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 74.29% 74.29%
=======================================
Files 11 11
Lines 1622 1622
=======================================
Hits 1205 1205
Misses 351 351
Partials 66 66 |
martin-majlis-s1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link: https://sentinelone.atlassian.net/browse/DSET-4430
🥅 Goal
Run the same OS and Go version as Open Telemetry Contrib
🛠️ Solution
In the PR #50 we have started to run tests also on Windows. But we should test as well with Go 1.20, since it's used by OpenTelemetry as well - OpenTelemetryContrib is running tests for Go 1.20 as well - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/build-and-test.yml#L225
🏫 Testing
Test for Go 1.19 and 1.20 are executed.