Spike for events, including mouse motion #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
mouse_motion_spike
branch
5 times, most recently
from
0d12856 to
fb3c942
Compare
Add some basic mouse events - hover, motion, click. Add a new motion-events example, cut down from another motion example. Add event_box append method, used by the example. Sort out how Slots work on Webview side, including formatting and event handling.
noahgibbs
force-pushed
the
mouse_motion_spike
branch
from
fb3c942 to
0507201
Compare
Schwad
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promised Pavan I'd do this.
Description
This has gotten a lot more involved than I planned. Somehow there's always one more thing to sort out.
This way "slot" is also a Webview display-side thing, which allows us to register event handlers (e.g. set an onmousemove). But it made sense to sort out a lot of slot stuff while I was adding it.
Image(if needed, helps for a faster review)
Checklist