Shoes widget not scarpe #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
shoes_widget_not_scarpe
branch
from
e02e231 to
796a172
Compare
noahgibbs
force-pushed
the
shoes_widget_not_scarpe
branch
from
796a172 to
15f32b5
Compare
noahgibbs
force-pushed
the
shoes_widget_not_scarpe
branch
from
15f32b5 to
b1d1583
Compare
gintama91
reviewed
Jul 12, 2023
| @@ -3,6 +3,8 @@ | |||
| --protected | |||
| --no-private | |||
| --template-path docs/yard/template | |||
| --tag incompatibility:"Incompatibilities with Shoes" | |||
There was a problem hiding this comment.
I like it, yeah :-) We can add other little categories like this if we want to, but I'm not sure which others we would need.
Schwad
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For compatibility and documentation, we're going to want to have portable Shoes stuff under Shoes, not Scarpe. I'm starting on that.
Eventually we'll probably want to match old Shoes classes (e.g. Shoes::Types::Button, not Shoes::Button). But one thing at a time.
Image
This lets us document a bit better:
Checklist