Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change my audio source #330

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Change my audio source #330

merged 3 commits into from
Jul 26, 2023

Conversation

Schwad
Copy link
Collaborator

@Schwad Schwad commented Jul 26, 2023

Screenshot

Screenshot 2023-07-26 at 14 18 22

Demo Video!! 🎥

GITHUB CAPS AT 10MB! The video is up on a tweet. Please watch. https://twitter.com/schwad_rb/status/1684194653535342593

For Reviewers

I love this app. But it has a homebrew dependency. But it's not specifically bloopsaphone related. Where should I put it?

Signed-off-by: Nick Schwaderer <nick.schwaderer@shopify.com>
@Schwad Schwad self-assigned this Jul 26, 2023
Signed-off-by: Nick Schwaderer <nick.schwaderer@shopify.com>
@noahgibbs
Copy link
Collaborator

That's an interesting question. We probably want some kind of directory of "stuff with strong local dependencies." We already have one or two (e.g. the one that uses parrot) in a no_ci directory. But something like that, where we've told CI not to run it.

This is one reason we eventually want packaging around apps - so that we can have a file for stuff like "here's how you install the dependencies" and "please don't run in CI."

In the mean time, directory. Maybe a no_ci directory outside legacy? I think we just check for no_ci as a path component in test_examples.rb.

@noahgibbs
Copy link
Collaborator

Also: this looks awesome. Way to go!

@Schwad
Copy link
Collaborator Author

Schwad commented Jul 26, 2023

@noahgibbs should this directory suit then? https://github.com/scarpe-team/scarpe/tree/main/examples/skip_ci

Also: this looks awesome. Way to go!

Thank you! It's super satisfying to have a neat little app with one neat little feature

@noahgibbs
Copy link
Collaborator

That dir looks good to me, yeah. When we later add packaging we'll be raiding stuff in there to separate it out regardless, so in the mean time, put it there.

@noahgibbs
Copy link
Collaborator

I've approved this, but you may want to move that file. I've approved, but I'll let you pick when to merge.

Signed-off-by: Nick Schwaderer <nick.schwaderer@shopify.com>
@Schwad Schwad merged commit 1cb4d3f into main Jul 26, 2023
@noahgibbs noahgibbs deleted the schwad_change_my_audio_source3 branch August 18, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants