Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear append destroy #339

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Clear append destroy #339

merged 3 commits into from
Jul 27, 2023

Conversation

noahgibbs
Copy link
Collaborator

@noahgibbs noahgibbs commented Jul 27, 2023

Description

Add append and clear operations to slots (e.g. stack, flow.) Add a test for it. Remove an old destroy_self alias we didn't use in favour of destroy (which we use a lot in Scarpe) and remove (the actual Shoes correct name.)

Technically we're not quite Shoes-compatible on append because we instance-eval for append, which removes the need for the Slot#app method. But that's basically always what we want. We can always break it later if we need to.

Image(if needed, helps for a faster review)

Screenshot 2023-07-27 at 15 32 11

Checklist

  • Run tests locally
  • Run linter(check for linter errors)

Copy link
Collaborator

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@noahgibbs noahgibbs merged commit 46424be into main Jul 27, 2023
@noahgibbs noahgibbs deleted the clear_append_destroy branch August 1, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants