Move glibui and libui into spikes #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These feel still in the spike stage and I want to make that clear. Yes, having them in this directory means they won't necessarily run now, but we're at the point where I don't want to cause confusion for folks navigating in lib/scarpe. Going forward, we can move display services back in, but I think we'd want to nominate and have a "responsible person" for each display service, in the README. I still find this code valuable as artifacts and am very happy to keep it in spikes. **For Reviewers** Is there context I'm missing here? Have these developed and should we keep them in this directory?
noahgibbs
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These feel still in the spike stage and I want to make that clear. Yes, having them in this directory means they won't necessarily run now, but we're at the point where I don't want to cause confusion for folks navigating in lib/scarpe.
Going forward, we can move display services back in, but I think we'd want to nominate and have a "responsible person" for each display service, in the README.
I still find this code valuable as artifacts and am very happy to keep it in spikes.
For Reviewers
Is there context I'm missing here? Have these developed and should we keep them in this directory?
Description
Image(if needed, helps for a faster review)
Checklist