para text #395
para text #395
Conversation
examples/para/para_text.rb
Outdated
| @@ -0,0 +1,14 @@ | |||
| Shoes.app do | |||
| stack do | |||
| @note = para " your note will appear here" | |||
There was a problem hiding this comment.
Would be good to fix the indentation here.
lacci/lib/shoes/widgets/para.rb
Outdated
| @@ -27,10 +27,18 @@ def initialize(*args, stroke: nil, size: :para, font: nil, hidden: false, **html | |||
| def text_children_to_items(text_children) | |||
| text_children.map { |arg| arg.is_a?(String) ? arg : arg.linkable_id } | |||
| end | |||
| def replace(*children) | |||
There was a problem hiding this comment.
Also funny indentation here.
lacci/lib/shoes/widgets/para.rb
Outdated
|
|
||
| def replace(*children) | ||
| @text_children = children | ||
| def text=(*children) |
There was a problem hiding this comment.
Will this ever be multiple items? I think an assignment will always just get one item. Not sure how this would work if you assigned an array.
There was a problem hiding this comment.
hm , ok n also in replace does it make diff if we use splat operator or no?
There was a problem hiding this comment.
Looks like sometimes it does?
noah@Noahs-MBP-3 scarpe % irb
irb(main):001> class Bobo; def text=(val); @text=val; end; def tsplat=(*args); @tsplat = args; end; end
=> :tsplat=
irb(main):002> b = Bobo.new
=> #<Bobo:0x00000001045f0c30>
irb(main):003> class Bobo; attr_reader :text; attr_reader :tsplat; end
=> [:tsplat]
irb(main):004> b.text
=> nil
irb(main):006> b.text = *[1, 2, 3]
=> [1, 2, 3]
irb(main):007> b.text
=> [1, 2, 3]
irb(main):008> b.tsplat = *[1, 2, 3]
=> [1, 2, 3]
irb(main):009> b.tsplat
=> [[1, 2, 3]]
There was a problem hiding this comment.
hm okay, but why do we/user pass array in either replace or in text...,(yeah there might be ppl who do but in that case should we try to convert array into string here or something?)
as of now even if we use splat operator if user passes anything other than string it just raises error if it dont have linkable id...
something like ?
if arg.is_a?(String)
arg
elsif arg.is_a?(Array)
arg
else
arg.linkable_id
end
There was a problem hiding this comment.
Normally you wouldn't use a splat operator in an assignment. If the user wants to assign an array, they can just assign the array value. Something like:
def text=(val)
@text=val
end
# or more succinctly:
attr_writer(:text)There was a problem hiding this comment.
Though never mind, attr_writer is no good because we need to make sure text gets sent via the text_childrentext_items display property.
|
sorry about indentation,i forgot to install vs code extension for it after reinstalling kubuntu |
|
changed this |
Description
para text, as it's functionality seems same as replace i just updated code for that
Image(if needed, helps for a faster review)
Checklist