Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a specific test object for CatsCradle, not Shoes::App #396

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

noahgibbs
Copy link
Collaborator

@noahgibbs noahgibbs commented Sep 30, 2023

Description

I've been mixing the CatsCradle module into Scarpe::App. That makes for a collision between para meaning "create a paragraph" and it meaning "find a paragraph that exists." This fixes that by creating a top-level test object to get the CatsCradle mixins instead of using Scarpe::App.

Checklist

  • Run tests locally

@noahgibbs
Copy link
Collaborator Author

Self-merging this one too - it's very small.

@noahgibbs noahgibbs merged commit c87b7d9 into main Oct 8, 2023
1 check passed
@noahgibbs noahgibbs deleted the catscradle_test_obj branch October 9, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant