Skip to content

Commit

Permalink
[3/3] Bump grpc to 1.33.1 to fix corruption when downloading CAS blobs
Browse files Browse the repository at this point in the history
Part 3: remove 1.32.x from third_party/grpc.

grpc-java versions 1.27 through 1.32 had a bug where messages could arrive
after the call was reported clsoed.  In the case of bazel, this meant that
in GrpcCacheClient, onNext could be called after onError.  This leads to
offset bookkeeping getting out of sync, and corrupts the CAS blob download.

bazelbuild#12927
  • Loading branch information
scele committed Feb 25, 2021
1 parent 84d27e3 commit 1840cfc
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 123 deletions.
2 changes: 1 addition & 1 deletion third_party/grpc/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ load("//tools/distributions:distribution_rules.bzl", "distrib_java_import", "dis

licenses(["notice"]) # Apache v2

exports_files(["grpc_1.32.0.patch", "grpc_1.33.1.patch"])
exports_files(["grpc_1.33.1.patch"])

package(default_visibility = ["//visibility:public"])

Expand Down
Binary file removed third_party/grpc/grpc-api-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-auth-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-context-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-core-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-netty-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-protobuf-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-protobuf-lite-1.32.2.jar
Binary file not shown.
Binary file removed third_party/grpc/grpc-stub-1.32.2.jar
Binary file not shown.
122 changes: 0 additions & 122 deletions third_party/grpc/grpc_1.32.0.patch

This file was deleted.

0 comments on commit 1840cfc

Please sign in to comment.