Fix transition scale bug

[besLisbeth]

Resolve #108

[schiehll]

Thank you as always @besLisbeth!

[schiehll]

Oh, actually, after testing it, looks like it broke the scale transition, will revert it.

[besLisbeth]

Oh no, I also tested it and did not find anything. Sorry then(

[schiehll]

No worries! I've tested it in the codesandbox and it broke the scale transition when the alert is leaving. Reverting it fixed. BUT looks like it fix only when there's more than one alert, when there's only one it's still broken. 🤔

We should investigate it.

[schiehll]

I've just tested the v5.1.0 (before the addition of support for multiple positions) and it worked...looks like it's broken since v5.2.0. Can you take a look in the code you added in that release and see what could be causing it?

[besLisbeth]

Yes, I found it. The problem with animation for the ONE leaving alert caused by condition rendering - react unmount TransitionGroup faster than it shows the exiting animation

[schiehll]

Yeah, that make sense! Did you thought in any possible solution?

[besLisbeth]

Yes! I move TransitionGroup higher on the DOM tree - to be stable and above the conditionally rendered Wrappers. But still, have problems with exiting animation - I'm trying to find the solution with 'react-select'

[besLisbeth]

I can't understand what caused such strange behaviour

[schiehll]

I'm not so worried about the react-select thing, for all we know it can be a problem with them, I'm more worried with the broken transition thing.

[schiehll]

Moving it higher in the tree makes it work not considering the react-select issue?

[besLisbeth]

It's strange. Now it works for the last alert in the array. But not for others.

[besLisbeth]

The alerts between 1 and alerts.length are not firing onExit event

[schiehll]

Weird stuff hahah can I see some code?

[besLisbeth]

Try to pull from there and not include react-select

[besLisbeth]

Code can be dirty)

[schiehll]

that's totally fine! will take a look and see if I can help somehow, thanks!

[besLisbeth]

Thank you!

[schiehll]

Hey @besLisbeth! I took a look in the code and couldn't find a solution. So for now I will revert the changes of v5.2, so you would only be able to use multiple alerts via multiple Contexts (unless you stay in v5.2.0 - v5.3.1).

If you find a solution, we can put the feature back.

[besLisbeth]

Sure, thank you. Sorry that I caused such inconvenience(

I'll try to find a solution.

[schiehll]

No worries! If you find a solution you are more then welcome to submit a new PR!