-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnLineBible export: Improve footnote handling #47
Comments
For very simple solutions, pull requests are appreciated. If you do not provide a pull request, please let the one who actually fixes it evaluate if a solution is very simple or very complex or something in between. Thanks. Can you share an example that actually contains a foot note? Footnotes in USX are made by the |
I tried to install OnLineBible 5.60 myself, and while I think I managed to import, check and compile my own Bible module, it does not show up in the Favourites window in Bibles? I am also getting the same warnings as you, plus I get a few dozen of these:
Do you know what the problem here is? In fact, not all of the lines that contain an odd number of dashes create this warning, also some of those lines have an even number of dashes. And in English, it is perfectly fine to have a sentence with an odd number of dashes - like this one. |
Why version 5.60? The latest version is 5.61. Here we mean when the ASCII dash character is in a row one after the other. For example: You, most likely, lines end with a dash. Online Bible does not like ASCII dash at the end of a line.
|
All cases when the Online Bible generates these error messages
The solution to the problem must be sought separately. I have selected all the verses in which the message of the first category occurs. I chose verses along with context: several paragraphs of context before and after the paragraph that contains the problem verse. All files with selected verses are in the aa.zip archive. I hope this set of verses makes it easier to find the source of the problem. I cannot provide the entire text of the Bible in its entirety, because I received this text under an agreement that forbids me to do so. At the moment, after some last change, the conversion is not successful. Here are the error messages:
Here is a list of the first category misspelled verses:
I think we should just drop the |
Can you share a download link? I was trying to find a download on https://onlinebible.com/, but was unable to. On http://www.onlinebible.org/titles the latest version available is 5.60.
I was trying to do my own conversion to see if there is any paragraph mode for custom Bibles, where it would matter if the verse ends with a newline. But as I wrote, I was unable to. So probably I will just remove newlines at end of verses as you suggested. Do you know what characters count as punctuation for OnLineBible? Is it just ASCII punctuation, or also Unicode punctuation? Or just dashes? If the line ends with a single punctuation, I can add an extra !! before it. (I hope it also works for ! as last character). Also, does adding the |
To update the Online Bible select
I think that all is not purely alpha/numeric
I've done testing. Using the This is the solution for either first or second category problem. But, at the end of the verse, all |
Thanks, I guess I should not run my Windows test VMs without virtual network card. And it appears the download happens from onlinebible.net - yet another domain, so I guess I should update the link in the README.
I settled for all Unicode characters with property "{PUNCT}" but without curly braces or backslash. We will see how correct this is. |
I tested poorly. I am correcting my mistake. The problem is solved by If footnotes are available with the Bible version you are using, then Selecting Footnotes feature will allow you to toggle the footnotes on and off.
When footnotes are turned on, that's what we see. But when the footnotes are turned off, then we see:
The punctuation to the right of the Close Brace
|
So let me summarize this more formally so I can implement it
So a more contrived example
should be transformed to
Also, as discussed in this comment, Footnotes (and also headlines which get converted to bold footnotes) should never contain markers for italic text, as footnotes are always rendered as italic text. Anything else I forgot about footnotes? |
I want to correct the example. should be transformed to
Here it is desirable to put things in order in the spaces. All footnotes are separated by spaces. Those characters that are moving before footnotes are appended to the previous token without spaces. |
There should be no footnotes inside footnotes. For example: This problem arose in Ps 3:1. I will create a new issue dedicated to this. |
Good catch. BibleMultiConverter's intermediate format already disallows this, but as we convert headlines to footnotes first, a footnote in a headline will inevitably create this problem.
Please keep it in this issue, if possible. |
I am converting USX to OnLineBible Format. Module has Descriptive titles.
Error occured here: footnote inside itself footnote markers
Formatting code
As a special case, it is also necessary to consider Ps 50:1-3.
It should be like this:
|
Another example that demonstrates that footnotes inside a Descriptive Title are acceptable. Using the
It should be like this:
Note that |
We need to add the back slash ( |
Also we need to wrap to new lines all |
Descriptive title paragraphs (psalm titles) were previously treated as headline paragraphs, but they should be normal paragraphs (containing verse numbers and Scripture text). As many Bible formats have special treatment for psalm titles (e.g. verse 0, or appending `/t` to the verse number), mark these verses with an individual CSS style, so that export formats can react on it. Currently, this is only used by OnLineBible format. See #47.
The descriptive titles was actually a bigger gotcha - I accidentally treated Also, your last comments may not be covered by the fix, but I myself fixed that onle one I'd suggest you try if these fixes fix your issues, and if not open a new issue (one issue for all OnLineBible export issues is enough). |
I don't understand English well, so I apologize if I understand something wrong. I realized that you are recommending that I create one general issue in case the latest changes do not help. I continue to experience problems, so I am ready to create one common issue for all subsequent problems. |
You understood correctly. :-) Put all OnLineBible related problems into #51. If you find any other problems (exporting to other formats or when importing), feel free to create new issues for them. |
The closing bracket must be at the end of the footnote text. If there is a NewLineCode
\&
after the closing bracket, then this creates a problem.BibleMultiConverter works as follows:
I propose to make a very simple solution to the problem, which will greatly improve the display of text in the Online Bible:
Put NewLineCode not at the end of the paragraph, but in front.
The text was updated successfully, but these errors were encountered: