-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String interpolation deprecation notices with PHP 8.2 #575
Comments
3 tasks
patrickallaert
added a commit
to patrickallaert/JMSTranslationBundle
that referenced
this issue
Feb 13, 2023
This was referenced Mar 27, 2023
Fix #575: Remove deprecation notices with string interpolation
patrickallaert/JMSTranslationBundle#1
Closed
goetas
added a commit
that referenced
this issue
Mar 27, 2023
Fix #575: Remove deprecation notices with string interpolation
@goetas, is it possible to get this fix (from v1.x branch) into beta version or you need new pull request for master at first? |
i plan to do some maintenance in the next days, it should be done soon |
balbinus
pushed a commit
to balbinus/JMSTranslationBundle
that referenced
this issue
Nov 19, 2023
Resolve pull request schmittjoh#576
michealmouner
added a commit
to lingoda/JMSTranslationBundle
that referenced
this issue
Apr 15, 2024
* Added gitattributes - exclude docs, tests from archive * Added template name and line number to exception thrown by DefaultApplyingNodeVisitor * Update FormExtractor.php Trying to get property 'key' of non-object * Fix --intl-icu option `--intl-icu` option was never interpreted because of a misuse of InputInterface::hasParameterOption * fix: require symfony/expression-language * Fallback to 'messages' domain when domain is null in trans|transchoice method * Support named argument for extracting domain * Bump nikic/php-parser to ^4.9 * Add attributes for routes * Allow to use translate controller without sensio/framework-extra-bundle * resolved deprecation notice with Symfony 5.4 PR resolves this deprecation: Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "JMS\TranslationBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message. * github actions, testing and coding standard, drop symfony 3.4 support * symfony 6 support * Handle properly promoted constructor properties default values * Fix schmittjoh#575: Remove deprecation notices with string interpolation Resolve pull request schmittjoh#576 * add void return signatures * chore: fix coding style * fix: fix wrong return type-hint depending on which symfony/translation version is installed * chore: bump symfony version for tests * chore(deps): upgrade nikic/php-parser@^5 * fix: prevent type error on choices array with optional keys * chore: fix phpcs + nikic/php-parser@4 compatibility * Fix tests * tests + ecs --------- Co-authored-by: iamvar <iamvar@gmail.com> Co-authored-by: Asmir Mustafic <goetas@gmail.com> Co-authored-by: Adam Wójs <adam@wojs.pl> Co-authored-by: Vladimir Pak <TheRatW@gmail.com> Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> Co-authored-by: Quentin Dreyer <quentin.dreyer@gmail.com> Co-authored-by: François-Xavier de Guillebon <deguif@gmail.com> Co-authored-by: Tomas Ludvik <ludviktomas@gmail.com> Co-authored-by: GRandFather <HenkerX64@users.noreply.github.com> Co-authored-by: Derek Stephen McLean <delboy1978uk@gmail.com> Co-authored-by: qkdreyer <quentin.dreyer@rgsystem.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
No deprecation notices should be thrown by the bundle
Actual behavior
Deprecation notices like:
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /vendor/jms/translation-bundle/DependencyInjection/JMSTranslationExtension.php on line 44
Steps to reproduce
The text was updated successfully, but these errors were encountered: