Test enhancement

[peter279k]

Q	A
Bug fix?	no
New feature?	no
Doc updated	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT

Changed log

• Add php-7.2 and php-7.3 version tests on Travis CI build.
• Using the ::class magic class string call to replace the class name string.
• Removing unused variables.
• Using the assertCount to assert the expected count value is same as result count value.
• According to the PHPUnit fixture reference, the setUp method is protected, not public.

When using the composer --prefer-lowest and --prefer-stable flags on php-7.2 version, this will cause the following coding style issue:

 php vendor/bin/phpcs                           19.5s
............................................E 45 / 45 (100%)



FILE: src/MetadataFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 36 | ERROR | Class MetadataFactory contains write-only property
    |       | $hierarchyMetadataClass.
    |       | (SlevomatCodingStandard.Classes.UnusedPrivateElements.WriteOnlyProperty)
--------------------------------------------------------------------------------

Time: 804ms; Memory: 8Mb

It seems that the private $hierarchyMetadataClass variable is unused.

To pass this coding style check, removing this variable.

[goetas]

Hi,

thanks for the PR. Looks good. I've noticed only one thing to be changed.

[goetas]

I guess this property should not have been removed

[peter279k]

I remove this variable because the coding style check will be failed.

Here is the history log.

[goetas]

it is the bug of the style checker, the property is being read at

metadata/src/MetadataFactory.php

Line 152 in 8eec675

$metadata = new $this->hierarchyMetadataClass();

[peter279k]

Ok. Reverting this change :).

[goetas]

To not have https://travis-ci.org/open-source-contributions/metadata/jobs/602205210 failing, you can assign hierarchyMetadataClass to a temporary local variable in

metadata/src/MetadataFactory.php

Line 152 in 8eec675

$metadata = new $this->hierarchyMetadataClass();

like:

$class = $this->hierarchyMetadataClass;
$metadata = new $class();

That is even more correct than the current code.

[peter279k]

$this->hierarchyMetadataClass;

Thanks for your reply. But it still has the same coding style issue.

[peter279k]

$this->hierarchyMetadataClass;

Thanks for your reply. But it still has the same coding style issue.

Ok. I got no coding style error finally. Forgiving my fault 😄.

[goetas]

👍

[goetas]

I think that there is an error in your rebase... I can see some extra commits

[peter279k]

I think that there is an error in your rebase... I can see some extra commits

Sorry. I make mistake about rebase...

Reverting commits.

[goetas]

Thank you