Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache support for anonymous classes (#79) #90

Merged
merged 3 commits into from
May 31, 2020
Merged

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented May 31, 2020

Q A
Bug fix? yes
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #79
License MIT

Fixing #79. Tested locally with:

  1. Cache none - no applicable then as the issue occurs only when trying to cache anonymous class meta data.
  2. Cache FileCache (default value) - working with anonymous classes after the my changes.
  3. Cache DoctrineCacheAdapter using ApcuCache and PhpFileCache - this adapter seem to work so no changes needed.
  4. Cache PsrCacheAdapter using cache.adapter.apcu and cache.adapter.filesystem - working with anonymous classes after the my changes.

Text copied from the orginal #87

Closes #87
Closes #79
Closes #88

@goetas
Copy link
Collaborator Author

goetas commented May 31, 2020

hello @jlekowski
I have tried both #87 and #88, I think that #87 was the best option. I have tried to re opne the PR, but github did not allow me to do so, so i have moved your commits to another branch and added a couple of fixes.

Thanks for your patience and work!

@jlekowski
Copy link
Contributor

@goetas, thanks for finding time and taking it - I am happy it's merged in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when trying to cache anonymous class
2 participants