Merge pull request #123 from bodgit/revert-113

Revert PR #113

progressbar.go

@@ -326,7 +326,7 @@ func DefaultBytes(maxBytes int64, description ...string) *ProgressBar {
 		OptionThrottle(65*time.Millisecond),
 		OptionShowCount(),
 		OptionOnCompletion(func() {
-			fmt.Printf("\n")
+			fmt.Fprint(os.Stderr, "\n")
 		}),
 		OptionSpinnerType(14),
 		OptionFullWidth(),
@@ -375,7 +375,7 @@ func Default(max int64, description ...string) *ProgressBar {
 		OptionShowCount(),
 		OptionShowIts(),
 		OptionOnCompletion(func() {
-			fmt.Printf("\n")
+			fmt.Fprint(os.Stderr, "\n")
 		}),
 		OptionSpinnerType(14),
 		OptionFullWidth(),

progressbar_test.go

@@ -440,13 +440,36 @@ func TestReaderToFile(t *testing.T) {
 	defer os.Remove(f.Name())
 	defer f.Close()
 
+	realStdout := os.Stdout
+	defer func() { os.Stdout = realStdout }()
+	r, fakeStdout, err := os.Pipe()
+	if err != nil {
+		t.Fatal(err)
+	}
+	os.Stdout = fakeStdout
+
 	bar := DefaultBytes(resp.ContentLength)
 	out := io.MultiWriter(f, bar)
 	_, err = io.Copy(out, resp.Body)
 	assert.Nil(t, err)
 	f.Sync()
 	f.Seek(0, 0)
 
+	if err := fakeStdout.Close(); err != nil {
+		t.Fatal(err)
+	}
+
+	b, err := ioutil.ReadAll(r)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if err := r.Close(); err != nil {
+		t.Fatal(err)
+	}
+
+	assert.Equal(t, "", string(b))
+
 	md5, err := md5sum(f)
 	assert.Nil(t, err)
 	assert.Equal(t, "d441819a800f8c90825355dfbede7266", md5)
@@ -471,13 +494,36 @@ func TestReaderToFileUnknownLength(t *testing.T) {
 	defer os.Remove(f.Name())
 	defer f.Close()
 
+	realStdout := os.Stdout
+	defer func() { os.Stdout = realStdout }()
+	r, fakeStdout, err := os.Pipe()
+	if err != nil {
+		t.Fatal(err)
+	}
+	os.Stdout = fakeStdout
+
 	bar := DefaultBytes(-1, " downloading")
 	out := io.MultiWriter(f, bar)
 	_, err = io.Copy(out, resp.Body)
 	assert.Nil(t, err)
 	f.Sync()
 	f.Seek(0, 0)
 
+	if err := fakeStdout.Close(); err != nil {
+		t.Fatal(err)
+	}
+
+	b, err := ioutil.ReadAll(r)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if err := r.Close(); err != nil {
+		t.Fatal(err)
+	}
+
+	assert.Equal(t, "", string(b))
+
 	md5, err := md5sum(f)
 	assert.Nil(t, err)
 	assert.Equal(t, "d441819a800f8c90825355dfbede7266", md5)