Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BarStartFilled and BarEndFille to Theme struct #203 #204

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Added BarStartFilled and BarEndFille to Theme struct #203 #204

merged 2 commits into from
Oct 3, 2024
+118 −19

Conversation

janpfeifer
Copy link
Contributor

@janpfeifer janpfeifer commented Oct 3, 2024 •
edited
Loading

  • Added BarStartFilled and BarEndFilled fields to Theme struct, and corresponding unit tests.
  • Added 3 predefined themes for users to choose from, if they want: ThemeDefault (no changes), ThemeASCII ("[===>...]") and ThemeUnicode using graphic symbols.
  • Small documentation additions and fixes.
  • Fixed issue where a call to ProgressBar.Finish() after it had already been finished by ProgressBar.Add(), would clear it, even if the user didn't request the clear.

Following up on issue #203

@janpfeifer
Added BarStartFilled and BarEndFilled fields to Theme struct.
d1e3b99 
Added 3 predefined themes for users to choose from, if they want: ThemeDefault (no changes), ThemeASCII ("[===>...]") and ThemeUnicode using graphic symbols.
Small documentation additions and fixes.
@janpfeifer
Expanded Theme tests, and covered new BarStartFilled and BarEndFilled.
e026913
@janpfeifer janpfeifer mentioned this pull request Oct 3, 2024
Closed
@schollz
Copy link
Owner

schollz commented Oct 3, 2024

Amazing!!!! Incredible work, thanks

@schollz schollz merged commit 0e8db3d into schollz:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janpfeifer @schollz