Prevent recreation of the aws_securityhub_member resource #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwinbaumannsbp
changed the title
marwinbaumannsbp
force-pushed
the
fix-sh-invite
branch
from
48f2dad to
4949df2
Compare
modules/security_hub/main.tf
Outdated
| @@ -14,6 +14,14 @@ resource "aws_securityhub_member" "default" { | |||
| email = each.value | |||
| invite = true | |||
There was a problem hiding this comment.
Have you tested setting invite = false? I believe the invite is useful when adding accounts via email but since we are using Organizations, I believe this should be set to false.
There was a problem hiding this comment.
Ferando and I did a little more research about the invite functionality and this is only needed when inviting member accounts that are not in our organization. We will remove this setting for now (since the default is false). More information: https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-accounts-add-invite.html
marwinbaumannsbp
force-pushed
the
fix-sh-invite
branch
from
4949df2 to
70c9f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the invite line in the aws_securityhub_member resource since this is only needed when inviting member accounts that are not in our organization.