Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epochs, dropout rate, learning rate options to MLP and example code #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add epochs, dropout rate, learning rate options to MLP and example code #10

wants to merge 1 commit into from

Conversation

kevinmershon
Copy link

No description provided.

@behrica
Copy link
Member

behrica commented Apr 1, 2022

Thanks for the PR. Looks awesome.
I will have a look soon.

behrica
behrica reviewed Apr 1, 2022
View reviewed changes
Copy link
Member

@behrica behrica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you convert the rich comment from line 91 onwards to a proper unit test and assert on the prediction result ?
Then we have a test, which runs as part of the test suite.

@behrica behrica mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behrica behrica behrica left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmershon @behrica