Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps config rehaul #28

Merged
merged 9 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions iop/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,59 @@ apiVersion: v2
name: iop
description: ScienceMesh IOP is the reference Federated Scientific Mesh platform
type: application
version: 0.3.1
version: 0.4.0
appVersion: 0.0.1
icon: https://developer.sciencemesh.io/logo.svg
home: https://developer.sciencemesh.io/
source: https://github.com/sciencemesh/sciencemesh
dependencies:
- name: revad
version: "1.4.2"
version: "1.6.1"
repository: "https://cs3org.github.io/charts"
alias: gateway
condition: gateway.enabled
- name: revad
version: "1.4.2"
version: "1.6.1"
repository: "https://cs3org.github.io/charts"
alias: storageprovider-home
condition: storageprovider-home.enabled
- name: revad
version: "1.4.2"
version: "1.6.1"
repository: "https://cs3org.github.io/charts"
alias: storageprovider-reva
condition: storageprovider-reva.enabled
- name: revad
version: "1.4.2"
version: "1.6.1"
repository: "https://cs3org.github.io/charts"
alias: storageprovider-public
condition: storageprovider-public.enabled
- name: revad
version: "1.6.1"
repository: "https://cs3org.github.io/charts"
alias: appprovider-collabora
condition: appprovider-collabora.enabled
- name: revad
version: "1.6.1"
repository: "https://cs3org.github.io/charts"
alias: appprovider-codimd
condition: appprovider-codimd.enabled
- name: wopiserver
version: "0.5.2"
version: "0.9.0"
repository: "https://cs3org.github.io/charts"
condition: wopiserver.enabled
maintainers:
- name: SamuAlfageme
email: samuel.alfageme.sainz@cern.ch
- name: glpatcern
email: Giuseppe.LoPresti@cern.ch
annotations:
artifacthub.io/changes: |
- kind: changed
description: Add app providers for Collabora and CodiMD and updated revad to support OCM
links:
- name: Apps config rehaul
url: https://github.com/sciencemesh/charts/pull/28
- name: Update revad to include OCM
url: https://github.com/cs3org/charts/pull/51
- kind: changed
description: Update revad chart to support customconfigmaps and imagePullSecrets
links:
Expand Down
12 changes: 11 additions & 1 deletion iop/ci/complete-iop-values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
gateway:
enabled: true
configFiles:
revad.toml: |
[grpc.services.gateway]
Expand Down Expand Up @@ -30,6 +29,7 @@ gateway:

[http.services.datagateway]
[http.services.ocmd]
[http.services.ocmprovider]
[http.services.ocdav]
[http.services.ocs]

Expand Down Expand Up @@ -106,5 +106,15 @@ storageprovider-public:
[grpc.services.authprovider.auth_managers.publicshares]
gateway_addr = "iop-gateway:19000"

appprovider-collabora:
enabled: true

appprovider-codimd:
enabled: true

wopiserver:
enabled: true
config:
codimd:
enabled: true
inturl: http://meshapps-codimd
17 changes: 17 additions & 0 deletions iop/templates/_helpers.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{{/*
Configure the wopiserver if apps are enabled
*/}}
{{ if or (index .Values "appprovider-codimd").enabled (index .Values "appprovider-collabora").enabled }}
wopiserver:
enabled: true
config:
codimd:
enabled: {{ (index .Values "appprovider-codimd").enabled }}
inturl: http://meshapps-codimd
{{ end }}
{{ if (index .Values "appprovider-codimd").enabled }}
codimd:
codimd:
extraEnvironmentVariables:
CMD_DOMAIN: https://{{ .Values.ingress.hostname }}
{{ end }}
12 changes: 8 additions & 4 deletions iop/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
gateway:
enabled: true

storageprovider-home:
enabled: false

Expand All @@ -10,5 +7,12 @@ storageprovider-reva:
storageprovider-public:
enabled: false

wopiserver:
# TODO not yet used
shareprovider-ocm:
enabled: false

appprovider-collabora:
enabled: false

appprovider-codimd:
enabled: false
2 changes: 1 addition & 1 deletion meshapps/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: meshapps
description: Umbrella-repository of apps supported by the IOP and its adapters
type: application
version: 0.0.3
version: 0.1.0
appVersion: 0.0.1
home: https://developer.sciencemesh.io/
dependencies:
Expand Down
16 changes: 9 additions & 7 deletions meshapps/README.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
# MESHApps

Colletion of apps supported by/compatible with the IOP and its adaptors.
Collection of apps supported by the IOP and its adaptors.

**Requirements:**
- `iop` chart version >= `0.4.0`
- `iop.wopiserver.enabled=true`
- `wopiserver` chart version >= `0.9.0`

## [Collabora CODE](https://hub.helm.sh/charts/stable/collabora-code)

- **Integration reference:** https://developer.sciencemesh.io/docs/technical-documentation/iop/deployment/kubernetes/wopiserver
- **Requirements:** `iop.wopiserver.enabled=true` - `iop` chart version >= `0.0.3`
- Integration reference: https://developer.sciencemesh.io/docs/technical-documentation/iop/deployment/kubernetes/wopiserver

## [CodiMD](https://hub.helm.sh/charts/codimd/codimd)

- **Integration reference:** https://developer.sciencemesh.io/docs/technical-documentation/integrations/codimd
- **Requirements:**
- `iop.wopiserver.enabled=true` and `iop.wopiserver.wopibridge.enabled=true`
- `iop` chart version >= `0.1.1` (`wopiserver` chart >= `0.2.0`)
- Integration reference: https://developer.sciencemesh.io/docs/technical-documentation/integrations/codimd

12 changes: 10 additions & 2 deletions meshapps/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
collabora-code:
collabora:
enabled: false
image:
tag: latest
Expand All @@ -20,9 +20,17 @@ codimd:
CMD_ALLOW_ANONYMOUS: true
CMD_ALLOW_ANONYMOUS_EDITS: true
CMD_ALLOW_ANONYMOUS_VIEWS: true
CMD_ALLOW_FREEURL: true
CMD_EMAIL: false
CMD_ALLOW_EMAIL_REGISTER: false
CMD_ALLOW_GRAVATAR: true
CMD_ALLOW_PDF_EXPORT: true
QT_QPA_PLATFORM:
NODE_TLS_REJECT_UNAUTHORIZED: 0
CMD_API_BODY_LIMIT: 210000
# CMD_URL_ADDPORT: true
CMD_URL_PATH: codimd
CMD_APPLIANCE_MODE: true
CMD_EMAIL: false
versionCheck: false
imageStorePersistentVolume:
enabled: false
Expand Down