-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit command #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you have access to heroku to debug if there are issues.
On further thought, this won't work because if the hook changes anything it is considered a failure. Will need to do some more refactoring. |
@Carreau I don't think I have access to that heroku app, my account is under steven.silvester at gmail.com. |
Oh I see what you mean, I can deploy this myself. |
Hi @blink1073! Note that I've not worked on this bot and hasn't used it besides learning that it can be used for backporting PRs by Min. Quickly glancing at the code I didn't see docstrings which otherwise could help me review something unknown by just knowing that the docstring declares the objective of a function. I guess a technical review point could be that it would be good if you add docstrings to any function you add or re-purpose to help newcomers! :) |
Converting to draft while I test in blink1073#1. I'm putting this aside for the weekend. |
To deploy you can just merge this. |
(and feel free to merge-try-revert to test if you need.) |
e11478c
to
ad87eb9
Compare
@Carreau I've finished. I ended up adding flake8 and GitHub Actions support. |
@consideRatio thanks for the feedback! I was pinging you and Chris as potential users of the new feature, no review required. |
Ok, let's just merge and see if things break. <3 |
@Carreau can you please add me as a collaborator on the repo? I can add the env secret needed for the test |
Sorry, I thought you were.
…On Wed, Mar 23, 2022 at 3:53 PM Steven Silvester ***@***.***> wrote:
@Carreau <https://github.com/Carreau> can you please add me as a
collaborator on the repo? I can add the env secret needed for the test
—
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR5T6AAWFZ2E4SEXGAUO3VBMV77ANCNFSM5RBNRBIQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I also invited you to the org in case you need even more permissions. |
Cheers |
blackify
into utility functions for prepping the repo and pushing workpre-commit
as a new commit and pushes.black
andpre-commit
in a PRrun
convenience function that prints the commandkeen
optional so it isn't needed in non-prod apps (costs $300/mo on team account)This is an on-demand alternative to the more disruptive "auto fixing pull requests" from https://pre-commit.ci/