-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Project icon positioning (#261) #265
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
It might be my imagination, but that icon looks higher than it used to be. Could you please compare against an older version of the theme? |
@stefanv It is definitely higher and smaller. Do you prefer it lower and bigger? Or just lower, but this size? |
I would like it to be restored to how it was, then we can discuss modifications another time. |
If we revert that, it would also mean reverting the fix that was merged in #230, and having to redesign that somehow. I just pushed another commit to this PR that looks like this: I tried to imitate the screenshot in #261 (comment) as closely as I could. It's mostly just a matter of tweaking the |
Thanks, Adam. I think if we add a tiny bit of extra space between the text and the logo, that's close enough and we can merge. |
Worth checking different zoom levels, and also the phone/tablet emulation in the web debugger window. |
Here is what it looked like 5 months ago (e3516b2): |
Looks like it's been present, in which case we can merge this and file a new issue for it. |
Will do. Thanks. |
This moves the project icon to appear like a superscript. See #261.