Error for missing breadcrumbs (scientific-python/blog.scientific-python.org#158) #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Note that the deployment failure is due to the newly introduced check: https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/6618df4e90d3a700082594cd#L152 It should pass after scientific-python/blog.scientific-python.org#215 is merged. |
alphapapa
force-pushed
the
wip/blog-158-missing-breadcrumbs
branch
from
070d63c to
1ff7b13
Compare
|
@stefanv @jarrodmillman This should be ready to merge now. |
…on.org#158) * layouts/partials/breadcrumbs.html: Log an error and fail the build if a breadcrumb is missing (i.e. if a page used in a breadcrumb has a missing "title" field in its front matter). This only applies to content pages which are referred to in breadcrumbs; other pages are still allowed to not have titles. See <scientific-python/blog.scientific-python.org#158>.
alphapapa
force-pushed
the
wip/blog-158-missing-breadcrumbs
branch
from
1ff7b13 to
472c9c6
Compare
jarrodmillman
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a breadcrumb is missing (i.e. if a page used in a breadcrumb has a
missing "title" field in its front matter).
This only applies to content pages which are referred to in
breadcrumbs; other pages are still allowed to not have titles.
See scientific-python/blog.scientific-python.org#158.
Output from the build (e.g.
make serve-dev) looks like: