Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update to anaconda-client v1.12.3 and simplify dependencies #67

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 22, 2024

Closes anaconda/anaconda-client#702

Notes for reviewers

To see that the bulk of this PR is reverting PR #64, note that if you diff this PR against PR #59's commit to main (66bc1b6) for cmd.sh there's no difference.

$ git diff 66bc1b6beedff9619cdff8f3361a06802c8f5874 HEAD -- cmd.sh  # no output
$ git diff 66bc1b6beedff9619cdff8f3361a06802c8f5874 HEAD -- environment.yml
diff --git a/environment.yml b/environment.yml
index 8dd12ba..be42ebb 100644
--- a/environment.yml
+++ b/environment.yml
@@ -2,5 +2,5 @@ name: upload-nightly-action
 channels:
   - conda-forge
 dependencies:
-  - python=3.11
-  - anaconda-client==1.12.1
+  - python=3.12
+  - anaconda-client==1.12.3

PR #64 added a check in CI though for an upload that would cause a removal of the exisitng project

- name: Test upload that forces removal first
uses: ./
with:
artifacts_path: dist
anaconda_nightly_upload_token: ${{ secrets.UPLOAD_TOKEN }}

and we can see from this PR's CI logs that is passing still, so anaconda-client v1.12.3 / anaconda/anaconda-client#708 is working as expected. 👍

+ anaconda --token *** upload --force --user scientific-python-nightly-wheels --label main dist/test_package-0.0.1-py3-none-any.whl
Uploading wheels to anaconda.org...
Using Anaconda API: https://api.anaconda.org/
Using "scientific-python-nightly-wheels" as upload username
Processing "dist/test_package-0.0.1-py3-none-any.whl"
Detecting file type...
File type is "Standard Python"
Extracting standard python attributes for upload
Warning:  Distribution "test_package-0.0.1-py3-none-any.whl" already exists. Removing.
Creating package "test-package"
Creating release "0.0.1"
Uploading file "scientific-python-nightly-wheels/test-package/0.0.1/test_package-0.0.1-py3-none-any.whl"

  0%|          | 0.00/1.27k [00:00<?, ?B/s]
6.76kB [00:00, 27.5kB/s]                   
6.76kB [00:00, 19.6kB/s]
Upload complete

standard python located at:
  https://anaconda.org/scientific-python-nightly-wheels/test-package

PR #64 was implimented because there was no interaction with the Anaconda team on anaconda/anaconda-client#702 as to when anything like anaconda/anaconda-client#708 would be implimented. :/

* As anaconda-client v1.12.3 adds the fixes needed for
  scientific-python/upload-nightly-action v0.4.0 upstream, updating to
  this version allows for reverting the logic added
  in scientific-python/upload-nightly-action v0.4.0 and removing curl and jq
  as required dependencies.
   - c.f. https://github.com/scientific-python/upload-nightly-action/releases/tag/0.4.0
* Revert logic from fix in scientific-python/upload-nightly-action v0.4.0.
* Update Python to 3.12.
* Rebuild the lock file for the updated environment.
* Update anaconda-client to v1.12.3.
* Update Python to v3.12.
@matthewfeickert matthewfeickert self-assigned this Feb 22, 2024
@matthewfeickert matthewfeickert added the enhancement New feature or request label Feb 22, 2024
@matthewfeickert matthewfeickert marked this pull request as ready for review February 22, 2024 23:09
@matthewfeickert
Copy link
Member Author

This will be v0.5.0.

@matthewfeickert matthewfeickert requested review from a team February 22, 2024 23:10
@matthewfeickert
Copy link
Member Author

Thanks for the fast review @jarrodmillman!

@matthewfeickert matthewfeickert merged commit b67d7fc into main Feb 23, 2024
2 checks passed
@matthewfeickert matthewfeickert deleted the feat/update-to-anaconda-client-1-12-3 branch February 23, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anaconda Cloud now causes error and package removal for upload of package version of same name
2 participants