♻️ Favor member_ids_ssim over file_set_ids_ssim #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For several years Hyrax has index `file_set_ids_ssim` as a verbatim copy of `member_ids_ssim`. With Hyrax 5, we're removing the `file_set_ids_ssim` from indexing; And given that it's been a verbatim copy since 2017 or so, it's relatively safe to assume that we can favor, without application impact, the `member_ids_ssim` over the `file_set_ids_ssim` value. It would be nice to have `file_set_ids_ssim` but not as a verbatim copy. Someday, we might have nice things. Related to: - samvera/hyrax#6513 - samvera/hyrax@7108409
kirkkwang
approved these changes
Feb 23, 2024
jeremyf
deleted the
favor-member_ids_ssim-over-longstanding-misnamed-file_set_ids_ssim
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For several years Hyrax has index
file_set_ids_ssimas a verbatim copyof
member_ids_ssim. With Hyrax 5, we're removing thefile_set_ids_ssimfrom indexing; And given that it's been a verbatimcopy since 2017 or so, it's relatively safe to assume that we can favor,
without application impact, the
member_ids_ssimover thefile_set_ids_ssimvalue.It would be nice to have
file_set_ids_ssimbut not as a verbatim copy.Someday, we might have nice things.
Related to: