I646 search dropdown #674
Merged
I646 search dropdown #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjproctor
force-pushed
the
i646-search-dropdown
branch
from
358d373
to
8e4b10b
Compare
Bringing over the commit from Hyrax referenced below. Ref: - samvera/hyrax@7a2d476
This commit removes `"My Collections"` and `"My Works"` search options. It adds search options for Generic Work, Image, Audio, Book, Compound Object, Newspaper, Pdf, and Video. When selected the appropriate filter is applied to the search. Ref: - #646
This commit adds 1em of padding to the x-axis on the search menu. Ref: - #646
Prior to this commit only signed in users could see the search options but that condition was removed. Ref: - #646
sjproctor
force-pushed
the
i646-search-dropdown
branch
from
8e4b10b
to
45ffeea
Compare
laritakr
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Remove "My Works" and "My Collections" from search drop down and adds all type facets
Refs
Expected Behavior Before Changes
Only logged in users can see search options that included
"All of Hyku","My Collections", and"My Works"in the dropdown menuExpected Behavior After Changes
All users can see the search options for
"All of Hyku","Generic Work","Image","Audio","Book","Compound Object","Newspaper","Pdf", and"Video".Screenshots / Video
Screen.Recording.2024-07-31.at.9.37.46.AM.mov