Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_standard_normal test is flaky #53

Open
kwinkunks opened this issue Sep 4, 2023 · 3 comments
Open

is_standard_normal test is flaky #53

kwinkunks opened this issue Sep 4, 2023 · 3 comments
Labels
bug Something isn't working testing Issue about testing

Comments

@kwinkunks
Copy link
Member

kwinkunks commented Sep 4, 2023 •
edited
Loading

Relax confidence level? Or could seed it.

Weirdly only seems flaky on Python 3.8.

image
@kwinkunks kwinkunks added the bug Something isn't working label Sep 4, 2023
kwinkunks added a commit that referenced this issue Sep 4, 2023
@kwinkunks
fix #53 again, sigh
0daa6c9
@kwinkunks kwinkunks reopened this Sep 4, 2023
@kwinkunks
Copy link
Member Author

Argh, still flaky. Clearly this test is not as robust as I hoped, maybe need to use something other than (or in addition to?) K-S.

@kwinkunks
Copy link
Member Author

Temporarily fixed this byusing default_rng with a seed -- but would rather have a test that a decent sample passes on.

kwinkunks added a commit that referenced this issue Sep 20, 2023
@kwinkunks
Reduce test flakiness, but not func flakiness, see #53
635fa48
@kwinkunks kwinkunks added the testing Issue about testing label Sep 27, 2023
@kwinkunks
Copy link
Member Author

Much better now but failed again on 3.9 here https://github.com/scienxlab/redflag/actions/runs/6385283773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working testing Issue about testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwinkunks