Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptService: add getScript(String,String) signature #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imagejan
Copy link
Member

This makes it easier to retrieve a ScriptInfo object from a script string (without going via File).

Closes #389.

@imagejan
Copy link
Member Author

I refactored ScriptServiceTest a bit to initialize the Context in a @Before method, and dispose it @After the tests.

@ctrueden what do you think about the re-use of the ScriptLanguage from ScriptInfoTest$BindingSizes? Should we instead make BindingSizes its own class within the tests? There are actually two nested ScriptLanguage implementations in the tests currently: ScriptInfoTest$BindingSizes and ScriptEngineTest$Rot13.

@imagejan imagejan force-pushed the scriptinfo-from-string branch from 0b2e588 to ab9dad2 Compare September 3, 2020 18:36
@imagejan imagejan force-pushed the scriptinfo-from-string branch from ab9dad2 to fc00c05 Compare December 18, 2020 19:10
This makes it easier to retrieve a ScriptInfo object from a script string (without going via File).

Closes #389.
@imagejan imagejan force-pushed the scriptinfo-from-string branch from fc00c05 to 0fc27eb Compare January 19, 2021 19:52
@ctrueden ctrueden force-pushed the master branch 3 times, most recently from 53b6733 to 3dc99c9 Compare November 7, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add convenience method to retrieve ScriptInfo/ModuleInfo from script
1 participant