Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure attestations for awkward-cpp sdist and wheels #3135

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 28, 2024

* awkward-cpp's sdists are named 'awkward-cpp-*.tar.gz' while the wheels
  are named 'awkward_cpp-*.whl', so to ensure that both the sdist and
  wheels get attestations use a wildcard to capture both '-' and '_'.
* Amends PR 3126.
@matthewfeickert matthewfeickert self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (b749e49) to head (8382bb7).
Report is 99 commits behind head on main.

Additional details and impacted files

see 88 files with indirect coverage changes

.github/workflows/deploy-cpp.yml Show resolved Hide resolved
@jpivarski jpivarski merged commit 53dc0e2 into scikit-hep:main May 28, 2024
43 checks passed
@matthewfeickert matthewfeickert deleted the ci/fix-awkward-cpp-wheel-signing branch May 29, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants