Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datetime.datetime.utcfromtimestamp deprecation warning #3338

Merged

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Dec 10, 2024

Fixes issue #3337

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating utcfromtimestamp, for keeping ahead of deprecations. I'm not sure why the environment variable SOURCE_DATE_EPOCH (not defined in my terminal...) gets precedence over time.time(), which I think should always work. If this were in the main codebase, I'd be more concerned because it would be introducing a dependence on the environment variable state, rather than anything in Python, but I think it's fine for the developer scripts.

The failing tests are all coming from JAX. I started running a test on the main branch to see if it's something that changed in JAX: https://github.com/scikit-hep/awkward/actions/runs/12259902669 All of these test were passing just a few days ago, so it might be due to a new version of JAX.

@ianna ianna merged commit 0cc66e8 into main Dec 21, 2024
39 checks passed
@ianna ianna deleted the ianna/3337-deprecationwarning-datetime_datetime_utcfromtimestamp branch December 21, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants