-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add boilerplate sub implementation #636
Conversation
We need to implement |
@HDembinski Question for you: should Hist - Hist be supported? I'd only want to support it in boost-histogram if Boost.Histogram supports it, or you have a good reason to support it only in boost-histogram. It's not hard to be explicit - Also, maybe we should switch to using signed storage so that subtraction (and negative weights?) work without having to change storages or throw an error. Technically, NumPy uses signed ints, IIRC. |
I think Hist should support what boost-histogram supports. The added benefit is that hist - hist can check whether this actually makes sense, it should fail if the axes are not the same. |
@HDembinski Sorry, my notation was sloppy. I wasn't suggesting Hist and boost-histogram diverge, I was just asking if a histogram histogram subtraction, |
aaa384a
to
62dcc23
Compare
62dcc23
to
1995bd7
Compare
Okay, needs tests now. @amangoel185 can you look into adding tests as outlined above? Or I might be able to later. |
Weighted and AtomicInt64 Boost.Histogram's do not support subtraction, so they don't support subtraction here either. |
73ee13d
to
4950bf1
Compare
@all-contributors please add @amangoel185 for code |
I've put up a pull request to add @amangoel185! 🎉 |
After this goes in, I think we should cut a patch release - there have been a few nice fixes, including one holding up a Hist PR, and Python 3.10 support needs to ship. |
Basic implementation for #632.
TODO: